GitHubMirror/sys
1
0
Fork 0
mirror of https://github.com/rwinkhart/sys.git synced 2026-08-29 13:26:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

unix: fix TestMmap crash on openbsd/386

Browse Source 
When adding Mprotect to TestMmap in CL 56172, PROT_WRITE was implicitly
assumed to also include PROT_READ. This is not necessarily true on all
OSes and makes TestMmap crash on openbsd/386.

As suggested my Mikio Hara fix it by also setting PROT_READ on the
memory mapping.

Fixes golang/go#21962

Change-Id: Ia789ab8b31f8dec0c3db23cc950ccdd4aab3db05
Reviewed-on: https://go-review.googlesource.com/65230
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
This commit is contained in:
Tobias Klauser
2017-09-21 19:16:43 +00:00
committed by Ian Lance Taylor
parent b6e1ae2164
commit 2320a9c158
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
unix/mmap_unix_test.go
+1 -1
View File
@@ -17,7 +17,7 @@ func TestMmap(t *testing.T) {
if err != nil {
t.Fatalf("Mmap: %v", err)
}
if err := unix.Mprotect(b, unix.PROT_WRITE); err != nil {
if err := unix.Mprotect(b, unix.PROT_READ|unix.PROT_WRITE); err != nil {
t.Fatalf("Mprotect: %v", err)
}