From 2320a9c15898af1b1b24f99700d5c1e957f9d8cf Mon Sep 17 00:00:00 2001 From: Tobias Klauser Date: Thu, 21 Sep 2017 11:26:02 +0200 Subject: [PATCH] unix: fix TestMmap crash on openbsd/386 When adding Mprotect to TestMmap in CL 56172, PROT_WRITE was implicitly assumed to also include PROT_READ. This is not necessarily true on all OSes and makes TestMmap crash on openbsd/386. As suggested my Mikio Hara fix it by also setting PROT_READ on the memory mapping. Fixes golang/go#21962 Change-Id: Ia789ab8b31f8dec0c3db23cc950ccdd4aab3db05 Reviewed-on: https://go-review.googlesource.com/65230 TryBot-Result: Gobot Gobot Reviewed-by: Ian Lance Taylor --- unix/mmap_unix_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/unix/mmap_unix_test.go b/unix/mmap_unix_test.go index 8de55fea..3258ca32 100644 --- a/unix/mmap_unix_test.go +++ b/unix/mmap_unix_test.go @@ -17,7 +17,7 @@ func TestMmap(t *testing.T) { if err != nil { t.Fatalf("Mmap: %v", err) } - if err := unix.Mprotect(b, unix.PROT_WRITE); err != nil { + if err := unix.Mprotect(b, unix.PROT_READ|unix.PROT_WRITE); err != nil { t.Fatalf("Mprotect: %v", err) }