GitHubMirror/sys
1
0
Fork 0
mirror of https://github.com/rwinkhart/sys.git synced 2026-08-28 04:46:44 -04:00
Code Issues Packages Projects Releases Wiki Activity

unix: enable TestPassFD and TestPoll on darwin/arm64

Browse Source 
Go 1.16 renamed the iOS port from darwin/arm64 to ios/arm64 and
darwin/arm64 was repurposed for the macOS ARM64 port (see
https://golang.org/doc/go1.16#darwin).

Now that Go 1.16 is the oldest supported release, the ios tag can be
used exclusively to detect iOS. Thus, TestPassFD and TestPoll which
ought to run on darwin/arm64 can now be enabled on that platform.

For golang/go#45696

Change-Id: I0b542af7a1b5ab194bf249d499c49e45bb55a2e1
Reviewed-on: https://go-review.googlesource.com/c/sys/+/353529
Trust: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
This commit is contained in:
Tobias Klauser
2021-10-02 10:42:28 +00:00
committed by Tobias Klauser
parent 39dca1131b
commit b1447f3f25
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
unix/syscall_unix_test.go
+2 -3
View File
@@ -167,7 +167,7 @@ func TestFcntlFlock(t *testing.T) {
// "-test.run=^TestPassFD$" and an environment variable used to signal
// that the test should become the child process instead.
func TestPassFD(t *testing.T) {
if (runtime.GOOS == "darwin" || runtime.GOOS == "ios") && runtime.GOARCH == "arm64" {
if runtime.GOOS == "ios" {
t.Skip("cannot exec subprocess on iOS, skipping test")
}
@@ -488,8 +488,7 @@ func TestDup(t *testing.T) {
}
func TestPoll(t *testing.T) {
if runtime.GOOS == "android" ||
((runtime.GOOS == "darwin" || runtime.GOOS == "ios") && runtime.GOARCH == "arm64") {
if runtime.GOOS == "android" || runtime.GOOS == "ios" {
t.Skip("mkfifo syscall is not available on android and iOS, skipping test")
}