switch back from golang.org/x/sys/execabs to os/exec (go1.19)

mirror of https://github.com/rwinkhart/go-winio.git synced 2026-09-05 16:47:31 -04:00

This reverts commit f2a56450f4, which switched
from os/exec to the golang.org/x/sys/execabs package to mitigate security
issues (mainly on Windows) with lookups resolving to binaries in the current
directory.

from the go1.19 release notes https://go.dev/doc/go1.19#os-exec-path

> ## PATH lookups
>
> Command and LookPath no longer allow results from a PATH search to be found
> relative to the current directory. This removes a common source of security
> problems but may also break existing programs that depend on using, say,
> exec.Command("prog") to run a binary named prog (or, on Windows, prog.exe) in
> the current directory. See the os/exec package documentation for information
> about how best to update such programs.
>
> On Windows, Command and LookPath now respect the NoDefaultCurrentDirectoryInExePath
> environment variable, making it possible to disable the default implicit search
> of “.” in PATH lookups on Windows systems.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

This commit is contained in:

Sebastiaan van Stijn

2024-04-22 20:31:03 +02:00

parent 3c9576c934

commit 92c1f57e85

1 changed files with 1 additions and 2 deletions

									
										pkg/security/grantvmgroupaccess_test.go
									
		+1
		-2
	
												View File
												
					@@ -5,12 +5,11 @@ package security

					import (

					import (

						"os"

						"os"

						"os/exec"

						"path/filepath"

						"path/filepath"

						"regexp"

						"regexp"

						"strings"

						"strings"

						"testing"

						"testing"

						exec "golang.org/x/sys/execabs"

					)

					)

					const (

					const (