mirror of
https://github.com/rwinkhart/sys.git
synced 2026-09-01 06:46:44 -04:00
This reverts CL 614082. Reason for revert: syscall.SyscallN allocates more than its syscall.SyscallX counterparts, producing perf-related test failures across the board. Updates #70197 Change-Id: I51107d909fcdbef4e65ee3f84932b2a0e7804f1b Reviewed-on: https://go-review.googlesource.com/c/sys/+/625375 Reviewed-by: Ian Lance Taylor <iant@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
114 lines
3.2 KiB
Go
114 lines
3.2 KiB
Go
// Copyright 2023 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
import (
|
|
"bytes"
|
|
"go/format"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestDLLFilenameEscaping(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
filename string
|
|
}{
|
|
{"no escaping necessary", "kernel32"},
|
|
{"escape period", "windows.networking"},
|
|
{"escape dash", "api-ms-win-wsl-api-l1-1-0"},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
// Write a made-up syscall into a temp file for testing.
|
|
const prefix = "package windows\n//sys Example() = "
|
|
const suffix = ".Example"
|
|
name := filepath.Join(t.TempDir(), "syscall.go")
|
|
if err := os.WriteFile(name, []byte(prefix+tt.filename+suffix), 0666); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Ensure parsing, generating, and formatting run without errors.
|
|
// This is good enough to show that escaping is working.
|
|
src, err := ParseFiles([]string{name})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
var buf bytes.Buffer
|
|
if err := src.Generate(&buf); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, err := format.Source(buf.Bytes()); err != nil {
|
|
t.Log(buf.String())
|
|
t.Fatal(err)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestSyscallXGeneration(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
wantsysfunc string
|
|
sig string
|
|
}{
|
|
{
|
|
name: "syscall with 2 params",
|
|
wantsysfunc: "syscall.Syscall",
|
|
sig: "Example(a1 *uint16, a2 *uint16) = ",
|
|
},
|
|
{
|
|
name: "syscall with 6 params",
|
|
wantsysfunc: "syscall.Syscall6",
|
|
sig: "Example(a1 *uint, a2 *uint, a3 *uint, a4 *uint, a5 *uint, a6 *uint) = ",
|
|
},
|
|
{
|
|
name: "syscall with 15 params",
|
|
wantsysfunc: "syscall.Syscall15",
|
|
sig: strings.ReplaceAll(`Example(a1 *uint, a2 *uint, a3 *uint, a4 *uint, a5 *uint, a6 *uint,
|
|
a7 *uint, a8 *uint, a9 *uint, a10 *uint, a11 *uint, a12 *uint,
|
|
a13 *uint, a14 *uint, a15 *uint) = `, "\n", ""),
|
|
},
|
|
{
|
|
name: "syscall with 18 params",
|
|
wantsysfunc: "syscall.SyscallN",
|
|
sig: strings.ReplaceAll(`Example(a1 *uint, a2 *uint, a3 *uint, a4 *uint, a5 *uint, a6 *uint,
|
|
a7 *uint, a8 *uint, a9 *uint, a10 *uint, a11 *uint, a12 *uint,
|
|
a13 *uint, a14 *uint, a15 *uint, a16 *uint, a17 *uint, a18 *uint) = `, "\n", ""),
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
// Write the syscall into a temp file for testing.
|
|
prefix := "package windows\n//sys " + tt.sig
|
|
suffix := ".Example"
|
|
name := filepath.Join(t.TempDir(), "syscall.go")
|
|
if err := os.WriteFile(name, []byte(prefix+"example"+suffix), 0666); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Ensure parsing, generating, and formatting run without errors.
|
|
// This is good enough to show that escaping is working.
|
|
src, err := ParseFiles([]string{name})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
var buf bytes.Buffer
|
|
if err := src.Generate(&buf); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, err := format.Source(buf.Bytes()); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if !strings.Contains(buf.String(), tt.wantsysfunc+"(") {
|
|
t.Fatalf("expected syscall func %q in buffer %s", tt.wantsysfunc, buf.String())
|
|
}
|
|
})
|
|
}
|
|
}
|