GitHubMirror/sys
1
0
Fork 0
mirror of https://github.com/rwinkhart/sys.git synced 2026-08-28 04:46:44 -04:00
Code Issues Packages Projects Releases Wiki Activity

unix: fix finalizer fd close bug in TestOpenByHandleAt

Browse Source 
The raw fd is successively wrapped using os.NewFile, so dont defer close
the raw fd, but instead use (*os.File).Close.

Fixes golang/go#49403

Change-Id: I1f4b12536ff0abea6b1680a4ff932b7eefa57162
Reviewed-on: https://go-review.googlesource.com/c/sys/+/361995
Trust: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
This commit is contained in:
Tobias Klauser
2021-11-07 10:43:06 +00:00
committed by Tobias Klauser
parent ebca88c72f
commit e0b2ad06fe
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
unix/syscall_linux_test.go
+2 -2
View File
@@ -720,10 +720,10 @@ func TestOpenByHandleAt(t *testing.T) {
if err != nil { if err != nil {
t.Fatalf("OpenByHandleAt: %v", err) t.Fatalf("OpenByHandleAt: %v", err)
} }
defer unix.Close(fd)
t.Logf("opened fd %v", fd) t.Logf("opened fd %v", fd)
f := os.NewFile(uintptr(fd), "") f := os.NewFile(uintptr(fd), "")
defer f.Close()
slurp, err := ioutil.ReadAll(f) slurp, err := ioutil.ReadAll(f)
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)