From 4f23f804edb0e01ed41cebeafbc82374889eddee Mon Sep 17 00:00:00 2001 From: Alex Brainman Date: Tue, 13 Jan 2026 17:24:02 +1100 Subject: [PATCH] windows: change Signal to alias syscall.Signal This CL changes Signal type from int to alias syscall.Signal to make Signal useful. In particular, you can pass windows.SIGINT to signal.Notify to produce behaviour similar to os.Interrupt and syscall.SIGINT. For golang/go#77076. Change-Id: Ie9243c30063e777f9898eba6d649c248a7f48fc5 Reviewed-on: https://go-review.googlesource.com/c/sys/+/735920 Reviewed-by: Quim Muntal LUCI-TryBot-Result: Go LUCI Reviewed-by: Cherry Mui Reviewed-by: Austin Clements --- windows/aliases.go | 1 + windows/syscall_windows.go | 14 -------------- 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/windows/aliases.go b/windows/aliases.go index 16f90560..96317966 100644 --- a/windows/aliases.go +++ b/windows/aliases.go @@ -8,5 +8,6 @@ package windows import "syscall" +type Signal = syscall.Signal type Errno = syscall.Errno type SysProcAttr = syscall.SysProcAttr diff --git a/windows/syscall_windows.go b/windows/syscall_windows.go index 738a9f21..d7664365 100644 --- a/windows/syscall_windows.go +++ b/windows/syscall_windows.go @@ -1490,20 +1490,6 @@ func Getgid() (gid int) { return -1 } func Getegid() (egid int) { return -1 } func Getgroups() (gids []int, err error) { return nil, syscall.EWINDOWS } -type Signal int - -func (s Signal) Signal() {} - -func (s Signal) String() string { - if 0 <= s && int(s) < len(signals) { - str := signals[s] - if str != "" { - return str - } - } - return "signal " + itoa(int(s)) -} - func LoadCreateSymbolicLink() error { return procCreateSymbolicLinkW.Find() }