GitHubMirror/sys
1
0
Fork 0
mirror of https://github.com/rwinkhart/sys.git synced 2026-09-05 00:27:17 -04:00
Code Issues Packages Projects Releases Wiki Activity

unix: fix several staticcheck issues

Browse Source 
Resolves a number of issues, except for the clen function being
unused on Linux, as that would require a larger refactor which
probably isn't strictly necessary.

$ staticcheck .
affinity_linux.go:94:8: const m3 is unused (U1000)
affinity_linux.go:95:8: const m4 is unused (U1000)
sendfile_test.go:41:2: the goroutine calls T.Fatal, which must be called in the same goroutine as the test (SA2002)
sendfile_test.go:47:6: this value of err is never used (SA4006)
syscall_linux_test.go:519:21: should use time.Since instead of time.Now().Sub (S1012)
syscall_linux_test.go:530:21: should use time.Since instead of time.Now().Sub (S1012)
syscall_test.go:66:2: this value of ts is never used (SA4006)
syscall_test.go:67:2: this value of ts is never used (SA4006)
syscall_unix.go:88:6: func clen is unused (U1000)

Change-Id: I2611b4559339cea758b5da27ea1f36fb8cc2df3f
Reviewed-on: https://go-review.googlesource.com/c/sys/+/188037
Run-TryBot: Matt Layher <mdlayher@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
This commit is contained in:
Matt Layher
2019-07-30 18:39:49 +00:00
parent fc99dfbffb
commit 1393eb0183
4 changed files with 20 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
unix/sendfile_test.go
+6 -1
View File
@@ -41,10 +41,15 @@ func TestSendfile(t *testing.T) {
go func() {
conn, err := ln.Accept()
if err != nil {
t.Fatal(err)
t.Errorf("failed to accept: %v", err)
return
}
defer conn.Close()
b, err := ioutil.ReadAll(conn)
if err != nil {
t.Errorf("failed to read: %v", err)
return
}
if string(b) != contents {
t.Errorf("contents not transmitted: got %s (len=%d), want %s", string(b), len(b), contents)
}