mirror of
https://github.com/rwinkhart/go-winio.git
synced 2026-08-30 05:46:50 -04:00
* Add lint and go generate stages to CI
Add CI step to verify `go generate` was run on repo.
Add linter stage to CI along with linter config file,
`.golangci.yml`.
Will likely prefer revive over static-check.
Updated README Contributing section on linting requirements.
Added sequence ordering to make sure lint and go generate stages run
before tests and build.
This way, build and tests are not run on code that could potentially:
1. not build due to `gofmt` issues;
2. contain bugs;
3. have to be re-submitted after issues are fixed; or
4. contain outdated Win32 syscall or other auto-generated files.
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
* Fixed linter issues
Code changes to satisfy linters:
- Ran `gofmt -s -w` on repo.
- Broke up long lines.
- When possible, changed names with incorrect initialism formatting
- Added exceptions for exported variables.
- Added exceptions for ALL_CAPS_WITH_UNDERSCORES code.
- Switched to using `windows` or `syscall` definitions if possible;
especially if some constants were unused.
- Added `_ =` to satisfy error linter, and acknowledge that errors are
being ignored.
- Switched to using `errors.Is` and `As` in places, elsewhere added
exceptions if error value was known to be `syscall.Errno`.
- Removed bare returns.
- Prevented variables from being overshadowed in certain places
(ignoring cases of overshadowing `err`).
- Renamed variables and functions (eg, `len`, `eventMetadata.bytes`) to
prevent shadowing pre-built functions and imported pacakges.
- Removed unused method receivers.
- Added exceptions to certain unused (unexported) constants and
functions.
- Deleted unused `once` from `pkg/etw.providerMap`.
- Renamed `noop.go` files to `main_other.go` or `doc.go`, to better fit
style recommendations.
- Added exceptions for non-secure use of SHA1 and weak crypto
libraries.
- Replaced `ioutil` with `io` and `os` (and `t.TempDir` in tests).
- Added fully exhaustive checks for `switch` statements in `pkg/etw`.
- Defined constant strings for `tools/mkwinsyscall`.
- Removed unnecessary conversions.
- Made sure `context.Cancel` was called.
Additionally, added `//go:build windows" constraints on files with
unexported code, since linter will complain about unused code on
non-Windows platforms.
Added a stub `main() {}` for `mkwinsyscall` for non-Windows builds, just in
case `//go:generate` directives are added to OS-agnostic files.
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
* PR: spelling, constants, fuzzing
Moved HVSocket fuzzing tests to separate file with go 1.18 build
constraint.
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
222 lines
6.2 KiB
Go
222 lines
6.2 KiB
Go
//go:build windows
|
|
// +build windows
|
|
|
|
package backuptar
|
|
|
|
import (
|
|
"archive/tar"
|
|
"bytes"
|
|
"io"
|
|
"os"
|
|
"path/filepath"
|
|
"reflect"
|
|
"testing"
|
|
|
|
"github.com/Microsoft/go-winio"
|
|
"golang.org/x/sys/windows"
|
|
)
|
|
|
|
func ensurePresent(t *testing.T, m map[string]string, keys ...string) {
|
|
for _, k := range keys {
|
|
if _, ok := m[k]; !ok {
|
|
t.Error(k, "not present in tar header")
|
|
}
|
|
}
|
|
}
|
|
|
|
func setSparse(t *testing.T, f *os.File) {
|
|
if err := windows.DeviceIoControl(windows.Handle(f.Fd()), windows.FSCTL_SET_SPARSE, nil, 0, nil, 0, nil, nil); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
// compareReaders validates that two readers contain the exact same data.
|
|
func compareReaders(t *testing.T, rActual io.Reader, rExpected io.Reader) {
|
|
const size = 8 * 1024
|
|
var bufExpected, bufActual [size]byte
|
|
var readCount int64
|
|
// Loop, first reading from rExpected, then reading the same amount from rActual.
|
|
// For each set of reads, compare the bytes to make sure they are identical.
|
|
// When we run out of data in rExpected, exit the loop.
|
|
for {
|
|
// Do a read from rExpected and see how many bytes we get.
|
|
nExpected, err := rExpected.Read(bufExpected[:])
|
|
if err == io.EOF && nExpected == 0 {
|
|
break
|
|
} else if err != nil && err != io.EOF {
|
|
t.Fatalf("Failed reading from rExpected at %d: %s", readCount, err)
|
|
}
|
|
// Do a ReadFull from rActual for the same number of bytes we got from rExpected.
|
|
if nActual, err := io.ReadFull(rActual, bufActual[:nExpected]); err != nil {
|
|
t.Fatalf("Only read %d bytes out of %d from rActual at %d: %s", nActual, nExpected, readCount, err)
|
|
}
|
|
readCount += int64(nExpected)
|
|
for i, bExpected := range bufExpected[:nExpected] {
|
|
if bExpected != bufActual[i] {
|
|
t.Fatalf("Mismatched bytes at %d. got 0x%x, expected 0x%x", i, bufActual[i], bExpected)
|
|
}
|
|
}
|
|
}
|
|
// Now we just need to make sure there isn't any further data in rActual.
|
|
var b [1]byte
|
|
if n, err := rActual.Read(b[:]); n != 0 || err != io.EOF {
|
|
t.Fatalf("rActual didn't return EOF at expected end. Read %d bytes with error %s", n, err)
|
|
}
|
|
}
|
|
|
|
func TestRoundTrip(t *testing.T) {
|
|
// Each test case is a name mapped to a function which must create a file and return its path.
|
|
// The test then round-trips that file through backuptar, and validates the output matches the input.
|
|
//
|
|
//nolint:gosec // G306: Expect WriteFile permissions to be 0600 or less
|
|
for name, setup := range map[string]func(*testing.T) string{
|
|
"normalFile": func(t *testing.T) string {
|
|
path := filepath.Join(t.TempDir(), "foo.txt")
|
|
if err := os.WriteFile(path, []byte("testing 1 2 3\n"), 0644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
return path
|
|
},
|
|
"normalFileEmpty": func(t *testing.T) string {
|
|
path := filepath.Join(t.TempDir(), "foo.txt")
|
|
f, err := os.OpenFile(path, os.O_CREATE|os.O_WRONLY, 0644)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer f.Close()
|
|
return path
|
|
},
|
|
"sparseFileEmpty": func(t *testing.T) string {
|
|
path := filepath.Join(t.TempDir(), "foo.txt")
|
|
f, err := os.OpenFile(path, os.O_CREATE|os.O_WRONLY, 0644)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer f.Close()
|
|
setSparse(t, f)
|
|
return path
|
|
},
|
|
"sparseFileWithNoAllocatedRanges": func(t *testing.T) string {
|
|
path := filepath.Join(t.TempDir(), "foo.txt")
|
|
f, err := os.OpenFile(path, os.O_CREATE|os.O_WRONLY, 0644)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer f.Close()
|
|
setSparse(t, f)
|
|
// Set file size without writing data to produce a file with size > 0
|
|
// but no allocated ranges.
|
|
if err := f.Truncate(1000000); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
return path
|
|
},
|
|
"sparseFileWithOneAllocatedRange": func(t *testing.T) string {
|
|
path := filepath.Join(t.TempDir(), "foo.txt")
|
|
f, err := os.OpenFile(path, os.O_CREATE|os.O_WRONLY, 0644)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer f.Close()
|
|
setSparse(t, f)
|
|
if _, err := f.WriteString("test sparse data"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
return path
|
|
},
|
|
"sparseFileWithMultipleAllocatedRanges": func(t *testing.T) string {
|
|
path := filepath.Join(t.TempDir(), "foo.txt")
|
|
f, err := os.OpenFile(path, os.O_CREATE|os.O_WRONLY, 0644)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer f.Close()
|
|
setSparse(t, f)
|
|
if _, err = f.Write([]byte("testing 1 2 3\n")); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
// The documentation talks about FSCTL_SET_ZERO_DATA, but seeking also
|
|
// seems to create a hole.
|
|
if _, err = f.Seek(1000000, 0); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, err = f.Write([]byte("more data later\n")); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
return path
|
|
},
|
|
} {
|
|
t.Run(name, func(t *testing.T) {
|
|
path := setup(t)
|
|
f, err := os.Open(path)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer f.Close()
|
|
|
|
fi, err := f.Stat()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
bi, err := winio.GetFileBasicInfo(f)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
br := winio.NewBackupFileReader(f, true)
|
|
defer br.Close()
|
|
var buf bytes.Buffer
|
|
tw := tar.NewWriter(&buf)
|
|
err = WriteTarFileFromBackupStream(tw, br, f.Name(), fi.Size(), bi)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
tr := tar.NewReader(&buf)
|
|
hdr, err := tr.Next()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
name, size, bi2, err := FileInfoFromHeader(hdr)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if name != filepath.ToSlash(f.Name()) {
|
|
t.Errorf("got name %s, expected %s", name, filepath.ToSlash(f.Name()))
|
|
}
|
|
if size != fi.Size() {
|
|
t.Errorf("got size %d, expected %d", size, fi.Size())
|
|
}
|
|
if !reflect.DeepEqual(*bi2, *bi) {
|
|
t.Errorf("got %#v, expected %#v", *bi2, *bi)
|
|
}
|
|
ensurePresent(t, hdr.PAXRecords, "MSWINDOWS.fileattr", "MSWINDOWS.rawsd")
|
|
// Reset file position so we can compare file contents.
|
|
// The file contents of the actual file should match what we get from the tar.
|
|
if _, err := f.Seek(0, 0); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
compareReaders(t, tr, f)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestZeroReader(t *testing.T) {
|
|
const size = 512
|
|
var b [size]byte
|
|
var bExpected [size]byte
|
|
var r zeroReader
|
|
n, err := r.Read(b[:])
|
|
if err != nil {
|
|
t.Fatalf("Unexpected read error: %s", err)
|
|
}
|
|
if n != size {
|
|
t.Errorf("Wrong read size. got %d, expected %d", n, size)
|
|
}
|
|
for i := range b {
|
|
if b[i] != bExpected[i] {
|
|
t.Errorf("Wrong content at index %d. got %d, expected %d", i, b[i], bExpected[i])
|
|
}
|
|
}
|
|
}
|