mirror of
https://github.com/rwinkhart/go-winio.git
synced 2026-08-28 04:46:50 -04:00
* Add lint and go generate stages to CI
Add CI step to verify `go generate` was run on repo.
Add linter stage to CI along with linter config file,
`.golangci.yml`.
Will likely prefer revive over static-check.
Updated README Contributing section on linting requirements.
Added sequence ordering to make sure lint and go generate stages run
before tests and build.
This way, build and tests are not run on code that could potentially:
1. not build due to `gofmt` issues;
2. contain bugs;
3. have to be re-submitted after issues are fixed; or
4. contain outdated Win32 syscall or other auto-generated files.
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
* Fixed linter issues
Code changes to satisfy linters:
- Ran `gofmt -s -w` on repo.
- Broke up long lines.
- When possible, changed names with incorrect initialism formatting
- Added exceptions for exported variables.
- Added exceptions for ALL_CAPS_WITH_UNDERSCORES code.
- Switched to using `windows` or `syscall` definitions if possible;
especially if some constants were unused.
- Added `_ =` to satisfy error linter, and acknowledge that errors are
being ignored.
- Switched to using `errors.Is` and `As` in places, elsewhere added
exceptions if error value was known to be `syscall.Errno`.
- Removed bare returns.
- Prevented variables from being overshadowed in certain places
(ignoring cases of overshadowing `err`).
- Renamed variables and functions (eg, `len`, `eventMetadata.bytes`) to
prevent shadowing pre-built functions and imported pacakges.
- Removed unused method receivers.
- Added exceptions to certain unused (unexported) constants and
functions.
- Deleted unused `once` from `pkg/etw.providerMap`.
- Renamed `noop.go` files to `main_other.go` or `doc.go`, to better fit
style recommendations.
- Added exceptions for non-secure use of SHA1 and weak crypto
libraries.
- Replaced `ioutil` with `io` and `os` (and `t.TempDir` in tests).
- Added fully exhaustive checks for `switch` statements in `pkg/etw`.
- Defined constant strings for `tools/mkwinsyscall`.
- Removed unnecessary conversions.
- Made sure `context.Cancel` was called.
Additionally, added `//go:build windows" constraints on files with
unexported code, since linter will complain about unused code on
non-Windows platforms.
Added a stub `main() {}` for `mkwinsyscall` for non-Windows builds, just in
case `//go:generate` directives are added to OS-agnostic files.
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
* PR: spelling, constants, fuzzing
Moved HVSocket fuzzing tests to separate file with go 1.18 build
constraint.
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
585 lines
11 KiB
Go
585 lines
11 KiB
Go
//go:build windows
|
|
// +build windows
|
|
|
|
package winio
|
|
|
|
import (
|
|
"bufio"
|
|
"bytes"
|
|
"context"
|
|
"errors"
|
|
"io"
|
|
"net"
|
|
"sync"
|
|
"syscall"
|
|
"testing"
|
|
"time"
|
|
"unsafe"
|
|
|
|
"golang.org/x/sys/windows"
|
|
)
|
|
|
|
var testPipeName = `\\.\pipe\winiotestpipe`
|
|
|
|
var aLongTimeAgo = time.Unix(1, 0)
|
|
|
|
func TestDialUnknownFailsImmediately(t *testing.T) {
|
|
_, err := DialPipe(testPipeName, nil)
|
|
if !errors.Is(err, syscall.ENOENT) {
|
|
t.Fatalf("expected ENOENT got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestDialListenerTimesOut(t *testing.T) {
|
|
l, err := ListenPipe(testPipeName, nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer l.Close()
|
|
var d = 10 * time.Millisecond
|
|
_, err = DialPipe(testPipeName, &d)
|
|
if !errors.Is(err, ErrTimeout) {
|
|
t.Fatalf("expected ErrTimeout, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestDialContextListenerTimesOut(t *testing.T) {
|
|
l, err := ListenPipe(testPipeName, nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer l.Close()
|
|
var d = 10 * time.Millisecond
|
|
ctx, cancel := context.WithTimeout(context.Background(), d)
|
|
defer cancel()
|
|
_, err = DialPipeContext(ctx, testPipeName)
|
|
if !errors.Is(err, context.DeadlineExceeded) {
|
|
t.Fatalf("expected context.DeadlineExceeded, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestDialListenerGetsCancelled(t *testing.T) {
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
l, err := ListenPipe(testPipeName, nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
ch := make(chan error)
|
|
defer l.Close()
|
|
go func(ctx context.Context, ch chan error) {
|
|
_, err := DialPipeContext(ctx, testPipeName)
|
|
ch <- err
|
|
}(ctx, ch)
|
|
time.Sleep(time.Millisecond * 30)
|
|
cancel()
|
|
err = <-ch
|
|
if !errors.Is(err, context.Canceled) {
|
|
t.Fatalf("expected context.Canceled, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestDialAccessDeniedWithRestrictedSD(t *testing.T) {
|
|
c := PipeConfig{
|
|
SecurityDescriptor: "D:P(A;;0x1200FF;;;WD)",
|
|
}
|
|
l, err := ListenPipe(testPipeName, &c)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer l.Close()
|
|
_, err = DialPipe(testPipeName, nil)
|
|
if !errors.Is(err, syscall.ERROR_ACCESS_DENIED) {
|
|
t.Fatalf("expected ERROR_ACCESS_DENIED, got %v", err)
|
|
}
|
|
}
|
|
|
|
func getConnection(cfg *PipeConfig) (client net.Conn, server net.Conn, err error) {
|
|
l, err := ListenPipe(testPipeName, cfg)
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
defer l.Close()
|
|
|
|
type response struct {
|
|
c net.Conn
|
|
err error
|
|
}
|
|
ch := make(chan response)
|
|
go func() {
|
|
c, err := l.Accept()
|
|
ch <- response{c, err}
|
|
}()
|
|
|
|
c, err := DialPipe(testPipeName, nil)
|
|
if err != nil {
|
|
return client, server, err
|
|
}
|
|
|
|
r := <-ch
|
|
if err = r.err; err != nil {
|
|
c.Close()
|
|
return nil, nil, err
|
|
}
|
|
|
|
return c, r.c, nil
|
|
}
|
|
|
|
func TestReadTimeout(t *testing.T) {
|
|
c, s, err := getConnection(nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer c.Close()
|
|
defer s.Close()
|
|
|
|
_ = c.SetReadDeadline(time.Now().Add(10 * time.Millisecond))
|
|
|
|
buf := make([]byte, 10)
|
|
_, err = c.Read(buf)
|
|
if !errors.Is(err, ErrTimeout) {
|
|
t.Fatalf("expected ErrTimeout, got %v", err)
|
|
}
|
|
}
|
|
|
|
func server(l net.Listener, ch chan int) {
|
|
c, err := l.Accept()
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
rw := bufio.NewReadWriter(bufio.NewReader(c), bufio.NewWriter(c))
|
|
s, err := rw.ReadString('\n')
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
_, err = rw.WriteString("got " + s)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
err = rw.Flush()
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
c.Close()
|
|
ch <- 1
|
|
}
|
|
|
|
func TestFullListenDialReadWrite(t *testing.T) {
|
|
l, err := ListenPipe(testPipeName, nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer l.Close()
|
|
|
|
ch := make(chan int)
|
|
go server(l, ch)
|
|
|
|
c, err := DialPipe(testPipeName, nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer c.Close()
|
|
|
|
rw := bufio.NewReadWriter(bufio.NewReader(c), bufio.NewWriter(c))
|
|
_, err = rw.WriteString("hello world\n")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
err = rw.Flush()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
s, err := rw.ReadString('\n')
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
ms := "got hello world\n"
|
|
if s != ms {
|
|
t.Errorf("expected '%s', got '%s'", ms, s)
|
|
}
|
|
|
|
<-ch
|
|
}
|
|
|
|
func TestCloseAbortsListen(t *testing.T) {
|
|
l, err := ListenPipe(testPipeName, nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
ch := make(chan error)
|
|
go func() {
|
|
_, err := l.Accept()
|
|
ch <- err
|
|
}()
|
|
|
|
time.Sleep(30 * time.Millisecond)
|
|
l.Close()
|
|
|
|
err = <-ch
|
|
if !errors.Is(err, ErrPipeListenerClosed) {
|
|
t.Fatalf("expected ErrPipeListenerClosed, got %v", err)
|
|
}
|
|
}
|
|
|
|
func ensureEOFOnClose(t *testing.T, r io.Reader, w io.Closer) {
|
|
b := make([]byte, 10)
|
|
w.Close()
|
|
n, err := r.Read(b)
|
|
if n > 0 {
|
|
t.Errorf("unexpected byte count %d", n)
|
|
}
|
|
if err != io.EOF {
|
|
t.Errorf("expected EOF: %v", err)
|
|
}
|
|
}
|
|
|
|
func TestCloseClientEOFServer(t *testing.T) {
|
|
c, s, err := getConnection(nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer c.Close()
|
|
defer s.Close()
|
|
ensureEOFOnClose(t, c, s)
|
|
}
|
|
|
|
func TestCloseServerEOFClient(t *testing.T) {
|
|
c, s, err := getConnection(nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer c.Close()
|
|
defer s.Close()
|
|
ensureEOFOnClose(t, s, c)
|
|
}
|
|
|
|
func TestCloseWriteEOF(t *testing.T) {
|
|
cfg := &PipeConfig{
|
|
MessageMode: true,
|
|
}
|
|
c, s, err := getConnection(cfg)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer c.Close()
|
|
defer s.Close()
|
|
|
|
type closeWriter interface {
|
|
CloseWrite() error
|
|
}
|
|
|
|
err = c.(closeWriter).CloseWrite()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
b := make([]byte, 10)
|
|
_, err = s.Read(b)
|
|
if !errors.Is(err, io.EOF) {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
func TestAcceptAfterCloseFails(t *testing.T) {
|
|
l, err := ListenPipe(testPipeName, nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
l.Close()
|
|
_, err = l.Accept()
|
|
if !errors.Is(err, ErrPipeListenerClosed) {
|
|
t.Fatalf("expected ErrPipeListenerClosed, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestDialTimesOutByDefault(t *testing.T) {
|
|
l, err := ListenPipe(testPipeName, nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer l.Close()
|
|
_, err = DialPipe(testPipeName, nil)
|
|
if !errors.Is(err, ErrTimeout) {
|
|
t.Fatalf("expected ErrTimeout, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestTimeoutPendingRead(t *testing.T) {
|
|
l, err := ListenPipe(testPipeName, nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer l.Close()
|
|
|
|
serverDone := make(chan struct{})
|
|
|
|
go func() {
|
|
s, err := l.Accept()
|
|
if err != nil {
|
|
t.Error(err)
|
|
return
|
|
}
|
|
time.Sleep(1 * time.Second)
|
|
s.Close()
|
|
close(serverDone)
|
|
}()
|
|
|
|
client, err := DialPipe(testPipeName, nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer client.Close()
|
|
|
|
clientErr := make(chan error)
|
|
go func() {
|
|
buf := make([]byte, 10)
|
|
_, err = client.Read(buf)
|
|
clientErr <- err
|
|
}()
|
|
|
|
time.Sleep(100 * time.Millisecond) // make *sure* the pipe is reading before we set the deadline
|
|
_ = client.SetReadDeadline(aLongTimeAgo)
|
|
|
|
select {
|
|
case err = <-clientErr:
|
|
if !errors.Is(err, ErrTimeout) {
|
|
t.Fatalf("expected ErrTimeout, got %v", err)
|
|
}
|
|
case <-time.After(100 * time.Millisecond):
|
|
t.Fatalf("timed out while waiting for read to cancel")
|
|
<-clientErr
|
|
}
|
|
<-serverDone
|
|
}
|
|
|
|
func TestTimeoutPendingWrite(t *testing.T) {
|
|
l, err := ListenPipe(testPipeName, nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer l.Close()
|
|
|
|
serverDone := make(chan struct{})
|
|
|
|
go func() {
|
|
s, err := l.Accept()
|
|
if err != nil {
|
|
t.Error(err)
|
|
return
|
|
}
|
|
time.Sleep(1 * time.Second)
|
|
s.Close()
|
|
close(serverDone)
|
|
}()
|
|
|
|
client, err := DialPipe(testPipeName, nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer client.Close()
|
|
|
|
clientErr := make(chan error)
|
|
go func() {
|
|
_, err = client.Write([]byte("this should timeout"))
|
|
clientErr <- err
|
|
}()
|
|
|
|
time.Sleep(100 * time.Millisecond) // make *sure* the pipe is writing before we set the deadline
|
|
_ = client.SetWriteDeadline(aLongTimeAgo)
|
|
|
|
select {
|
|
case err = <-clientErr:
|
|
if !errors.Is(err, ErrTimeout) {
|
|
t.Fatalf("expected ErrTimeout, got %v", err)
|
|
}
|
|
case <-time.After(100 * time.Millisecond):
|
|
t.Fatalf("timed out while waiting for write to cancel")
|
|
<-clientErr
|
|
}
|
|
<-serverDone
|
|
}
|
|
|
|
type CloseWriter interface {
|
|
CloseWrite() error
|
|
}
|
|
|
|
func TestEchoWithMessaging(t *testing.T) {
|
|
c := PipeConfig{
|
|
MessageMode: true, // Use message mode so that CloseWrite() is supported
|
|
InputBufferSize: 65536, // Use 64KB buffers to improve performance
|
|
OutputBufferSize: 65536,
|
|
}
|
|
l, err := ListenPipe(testPipeName, &c)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer l.Close()
|
|
|
|
listenerDone := make(chan bool)
|
|
clientDone := make(chan bool)
|
|
go func() {
|
|
// server echo
|
|
conn, e := l.Accept()
|
|
if e != nil {
|
|
t.Error(err)
|
|
return
|
|
}
|
|
defer conn.Close()
|
|
|
|
time.Sleep(500 * time.Millisecond) // make *sure* we don't begin to read before eof signal is sent
|
|
_, _ = io.Copy(conn, conn)
|
|
_ = conn.(CloseWriter).CloseWrite()
|
|
close(listenerDone)
|
|
}()
|
|
timeout := 1 * time.Second
|
|
client, err := DialPipe(testPipeName, &timeout)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer client.Close()
|
|
|
|
go func() {
|
|
// client read back
|
|
bytes := make([]byte, 2)
|
|
n, e := client.Read(bytes)
|
|
if e != nil {
|
|
t.Error(err)
|
|
return
|
|
}
|
|
if n != 2 {
|
|
t.Errorf("expected 2 bytes, got %v", n)
|
|
return
|
|
}
|
|
close(clientDone)
|
|
}()
|
|
|
|
payload := make([]byte, 2)
|
|
payload[0] = 0
|
|
payload[1] = 1
|
|
|
|
n, err := client.Write(payload)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if n != 2 {
|
|
t.Fatalf("expected 2 bytes, got %v", n)
|
|
}
|
|
_ = client.(CloseWriter).CloseWrite()
|
|
<-listenerDone
|
|
<-clientDone
|
|
}
|
|
|
|
func TestConnectRace(t *testing.T) {
|
|
l, err := ListenPipe(testPipeName, nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer l.Close()
|
|
go func() {
|
|
for {
|
|
s, err := l.Accept()
|
|
if errors.Is(err, ErrPipeListenerClosed) {
|
|
return
|
|
}
|
|
|
|
if err != nil {
|
|
t.Error(err)
|
|
return
|
|
}
|
|
s.Close()
|
|
}
|
|
}()
|
|
|
|
for i := 0; i < 1000; i++ {
|
|
c, err := DialPipe(testPipeName, nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
c.Close()
|
|
}
|
|
}
|
|
|
|
func TestMessageReadMode(t *testing.T) {
|
|
var wg sync.WaitGroup
|
|
defer wg.Wait()
|
|
|
|
l, err := ListenPipe(testPipeName, &PipeConfig{MessageMode: true})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer l.Close()
|
|
|
|
msg := ([]byte)("hello world")
|
|
|
|
wg.Add(1)
|
|
go func() {
|
|
defer wg.Done()
|
|
s, err := l.Accept()
|
|
if err != nil {
|
|
t.Error(err)
|
|
return
|
|
}
|
|
_, err = s.Write(msg)
|
|
if err != nil {
|
|
t.Error(err)
|
|
return
|
|
}
|
|
s.Close()
|
|
}()
|
|
|
|
c, err := DialPipe(testPipeName, nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer c.Close()
|
|
|
|
setNamedPipeHandleState := syscall.NewLazyDLL("kernel32.dll").NewProc("SetNamedPipeHandleState")
|
|
|
|
p := c.(*win32MessageBytePipe)
|
|
mode := uint32(windows.PIPE_READMODE_MESSAGE)
|
|
if s, _, err := setNamedPipeHandleState.Call(uintptr(p.handle), uintptr(unsafe.Pointer(&mode)), 0, 0); s == 0 {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
ch := make([]byte, 1)
|
|
var vmsg []byte
|
|
for {
|
|
n, err := c.Read(ch)
|
|
if err == io.EOF { //nolint:errorlint
|
|
break
|
|
}
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if n != 1 {
|
|
t.Fatal("expected 1: ", n)
|
|
}
|
|
vmsg = append(vmsg, ch[0])
|
|
}
|
|
if !bytes.Equal(msg, vmsg) {
|
|
t.Fatalf("expected %s: %s", msg, vmsg)
|
|
}
|
|
}
|
|
|
|
func TestListenConnectRace(t *testing.T) {
|
|
for i := 0; i < 50 && !t.Failed(); i++ {
|
|
var wg sync.WaitGroup
|
|
wg.Add(1)
|
|
go func() {
|
|
c, err := DialPipe(testPipeName, nil)
|
|
if err == nil {
|
|
c.Close()
|
|
}
|
|
wg.Done()
|
|
}()
|
|
s, err := ListenPipe(testPipeName, nil)
|
|
if err != nil {
|
|
t.Error(i, err)
|
|
} else {
|
|
s.Close()
|
|
}
|
|
wg.Wait()
|
|
}
|
|
}
|