GitHubMirror/go-winio
1
0
Fork 0
mirror of https://github.com/rwinkhart/go-winio.git synced 2026-09-05 16:47:31 -04:00
Code Issues Packages Projects Releases Wiki Activity

Switch from sycall to windows (#295)

Browse Source 
Where ever possible, use `golang.org/x/sys/windows` instead of `syscall`
(which has been deprecated since go1.11).

Using `windows.LocalFree` requires using `unsafe.Pointer`, which ensures
that the Go garbage collector does not try to free memory pre-maturely
if it was previously declared as a pointer.

Since `syscall.Handle` is part of API for `vhd` package, it was left
unchanged.

For security descriptor functions, switch to using
`windows.SECURITY_DESCRIPTOR` to avoid unnecessary byte manipulation and
panics due to missing input validation and error checking.

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
This commit is contained in:
Hamza El-Saawy
2023-08-07 14:06:05 -04:00
committed by GitHub
parent fec52bd5aa
commit 9f0d5dc7d2
20 changed files with 291 additions and 251 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pipe_test.go
+4 -5
View File
@@ -11,7 +11,6 @@ import (
"io"
"net"
"sync"
"syscall"
"testing"
"time"
"unsafe"
@@ -25,8 +24,8 @@ var aLongTimeAgo = time.Unix(1, 0)
func TestDialUnknownFailsImmediately(t *testing.T) {
_, err := DialPipe(testPipeName, nil)
if !errors.Is(err, syscall.ENOENT) {
t.Fatalf("expected ENOENT got %v", err)
if !errors.Is(err, windows.ERROR_FILE_NOT_FOUND) {
t.Fatalf("expected ERROR_FILE_NOT_FOUND got %v", err)
}
}
@@ -88,7 +87,7 @@ func TestDialAccessDeniedWithRestrictedSD(t *testing.T) {
}
defer l.Close()
_, err = DialPipe(testPipeName, nil)
if !errors.Is(err, syscall.ERROR_ACCESS_DENIED) {
if !errors.Is(err, windows.ERROR_ACCESS_DENIED) {
t.Fatalf("expected ERROR_ACCESS_DENIED, got %v", err)
}
}
@@ -596,7 +595,7 @@ func TestMessageReadMode(t *testing.T) {
}
defer c.Close()
setNamedPipeHandleState := syscall.NewLazyDLL("kernel32.dll").NewProc("SetNamedPipeHandleState")
setNamedPipeHandleState := windows.NewLazyDLL("kernel32.dll").NewProc("SetNamedPipeHandleState")
p := c.(*win32MessageBytePipe)
mode := uint32(windows.PIPE_READMODE_MESSAGE)