From 650a2e464c7458a1d355d7bb5affad1eec1bfbb6 Mon Sep 17 00:00:00 2001 From: Hamza El-Saawy <84944216+helsaawy@users.noreply.github.com> Date: Fri, 28 Oct 2022 12:31:56 -0400 Subject: [PATCH] Update version, remove deprecated linter (#265) `structcheck` is deprecated. Update golanci-lint to 1.50. Signed-off-by: Hamza El-Saawy --- .github/workflows/ci.yml | 2 +- .golangci.yml | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5770f93..bbd32da 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,7 +18,7 @@ jobs: - name: Run golangci-lint uses: golangci/golangci-lint-action@v3 with: - version: v1.48 + version: v1.50 args: >- --verbose --timeout=5m diff --git a/.golangci.yml b/.golangci.yml index d527ea5..2bf84e3 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -20,7 +20,6 @@ linters: - gofmt # files are gofmt'ed - gosec # security - nilerr # returns nil even with non-nil error - - structcheck # unused struct fields - unparam # unused function params issues: @@ -94,6 +93,8 @@ linters-settings: disabled: true - name: flag-parameter # excessive, and a common idiom we use disabled: true + - name: unhandled-error # warns over common fmt.Print* and io.Close; rely on errcheck instead + disabled: true # general config - name: line-length-limit arguments: