GitHubMirror/go-winio
1
0
Fork 0
mirror of https://github.com/rwinkhart/go-winio.git synced 2026-09-05 08:37:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #138 from microsoft/etw-write-error

Browse Source 
etwlogrus: Ignore error from ETW WriteEvent
This commit is contained in:
John Starks
2019-05-08 08:21:23 -07:00
committed by GitHub
parent 1bcf844dd4 2093f10e12
commit 2be8053e58
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/etwlogrus/hook.go
+8 -1
View File
@@ -88,10 +88,17 @@ func (h *Hook) Fire(e *logrus.Entry) error {
fields = append(fields, etw.SmartField(logrus.ErrorKey, e.Data[logrus.ErrorKey])) fields = append(fields, etw.SmartField(logrus.ErrorKey, e.Data[logrus.ErrorKey]))
} }
return h.provider.WriteEvent( // Firing an ETW event is essentially best effort, as the event write can
// fail for reasons completely out of the control of the event writer (such
// as a session listening for the event having no available space in its
// buffers). Therefore, we don't return the error from WriteEvent, as it is
// just noise in many cases.
h.provider.WriteEvent(
"LogrusEntry", "LogrusEntry",
etw.WithEventOpts(etw.WithLevel(level)), etw.WithEventOpts(etw.WithLevel(level)),
fields) fields)
return nil
} }
// Close cleans up the hook and closes the ETW provider. If the provder was // Close cleans up the hook and closes the ETW provider. If the provder was