From afad2b7ee8336334ee6c0617ab783611771bff1e Mon Sep 17 00:00:00 2001 From: Randall Winkhart Date: Sat, 26 Oct 2024 23:28:37 -0400 Subject: [PATCH] Properly cap vinculum range at 3,999,999 --- convertroman.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/convertroman.go b/convertroman.go index 76ef5c8..694578c 100644 --- a/convertroman.go +++ b/convertroman.go @@ -10,15 +10,20 @@ var ( ) // FromInt converts an integer value to a roman numeral string. +// The function will return "0" if the input integer is less than 1. +// The function will return "OOB" if the input integer is greater than +// or equal to 4,000,000 (the roman numeral vinculum limit). func FromInt(input int) string { // check the range of the input integer if input < 1 { return "0" } else if input < 4000 { return baseRange(input) - } else { + } else if input < 4000000 { thousands, remainder := separateThousands(input) return vinculumRange(thousands) + baseRange(remainder) + } else { + return "OOB" } }